Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212903509
Thanks, I will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212870271
@swill This is ready for merge, has the required LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212842649
LGTM. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user srinivas-gandikota commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212781868
LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-199189940
Need one more LGTM, anyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-173955971
Ping @wilderrodrigues see answer above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-173474463
@remibergsma RebootCoomand is used by rebootVirtualMachine API. Refer to
test_03_reboot_vm in smoke/test_vm_life_cycle.py. It is also used in
rebootSystemVm API
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-173196336
@koushik-das
Is there any integration test that can cover this?
If so, we will run it and get this merged. Otherwise I can help writing one
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-163862343
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1200#discussion_r47190062
--- Diff: core/src/com/cloud/agent/api/RebootCommand.java ---
@@ -19,29 +19,25 @@
package com.cloud.agent.api;
-import com.cloud.
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1200#discussion_r47093362
--- Diff: core/src/com/cloud/agent/api/RebootCommand.java ---
@@ -19,29 +19,25 @@
package com.cloud.agent.api;
-import com.cloud.vm.Virt
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-163166411
As part of this noticed that RebootRouterCommand is obsolete, will create a
separate PR for removing that once this is accepted.
---
If your project is set up
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1200
CLOUDSTACK-9130: Make RebootCommand similar to start/stop/migrate ageâ¦
â¦nt commands w.r.t. "execute in sequence" flag
RebootCommand now behaves in the same way as start/stop/mig
14 matches
Mail list logo
