Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164405051
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
---
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164399579
thanks @SudharmaJain building again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164350819
Fixed the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164151105
Nice find @DaanHoogland Can you please fix this @SudharmaJain ? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47431643
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java
---
@@ -0,0 +1,35 @@
+package com.cl
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164149214
Go for it, @remibergsma! Changes LGTM :+1:
@DaanHoogland: should we wait for the outcome of your build?
Cheers,
Wilder
---
If your pr
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47431578
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
@@ -236,4 +236,15 @@ public static Str
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164148706
lgtm, doing a test build, now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164146123
Ping @wilderrodrigues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47336103
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
@@ -236,4 +236,15 @@ public static String
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-163578421
Thanks for testing and adding the screenshots, @SudharmaJain!
Waiting for you reply on the unit test question I asked.
---
If your project is set u
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47212450
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
@@ -236,4 +236,15 @@ public static Str
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-163570286
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/1196
CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterpriseâ¦
⦠Server 10 SP2 and SP3"
ISSUE
STOP-START of SUSE Linux VMs fail, as PV-bootloader-args
15 matches
Mail list logo
