[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162984674 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162941648 Hi @wilderrodrigues, I tested it just now! Looking good! Ran against Ubuntu 14.04 KVM management/hypervisor. ``` Test redundant router inter

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162860695 Ping @DaanHoogland @remibergsma @miguelaferreira @borisroman @bhaisaab @karuturi Since I changed the checkrouter.sh, also used by rVPCs, I will run

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162839426 Ping @remibergsma @bhaisaab @DaanHoogland @miguelaferreira @borisroman I'm currently running the other tests, but feel free to start testing now.

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1189 CLOUDSTACK-9118 - As a Developer I want the checkrouter.sh script to report the right information about RVR routers state This PR fixes the RVR routers state information retrieved by th