Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-219629360
closed as I have more commits for restart network, restartvpc, update
network, upgrade network (from old version 4.5 or before).
the downtime of network is r
Github user ustcweizhou closed the pull request at:
https://github.com/apache/cloudstack/pull/1198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-216207184
@ustcweizhou thanks, can you rebase against latest master and share state
of your PR
this looks like an interesting change we should have
tag:needlov
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-173196826
Ping @remibergsma @borisroman
This one needs an integration test to cover the changes. Worth writing one
for. Who got time left? :)
Cheers
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-164199095
@DaanHoogland @wilderrodrigues
assume there are two routers now routerA (master) and routerB (backup).
if we destroy routerA (master) at first, then rou
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-164186641
I will look at improving the integration tests but can you do the
improvements to the code as @wilderrodrigues suggested (or comment on them)?
---
If your pro
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163875769
@wilderrodrigues thanks!
I am not in a hurry to merge it into 4.6 or master. Let's merge it after
fully testing (scripts and functional test) and 2+ LGTM.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163867468
@remibergsma @DaanHoogland
This PR Looks Okay To Me, no good, but okay. Please merge it and I will
improve the code and add Marvin tests to cover i
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1198#discussion_r47328907
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2558,6 +2575,62 @@ public boolean
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163864347
FYI, run integration tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163557163
I know this issue. You can get it working with @Autowire and @Quialifier
annotations. If BaseCmd does the same, then it should be fine.
Cheers,
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163554256
@wilderrodrigues
I used VirtualNetworkApplianceService at first, and met an issue like:
"spring autowiring with unique beans: Spring expected single
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1198#discussion_r47204914
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2558,6 +2575,62 @@ public boolean res
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1198#discussion_r47204055
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2558,6 +2575,62 @@ public boolean
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163541774
Hi @ustcweizhou,
The content is a bit misleading because you used the
```VpcVirtualNetworkApplianceService``` instead of
```VirtualNetworkAppliance
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163540200
@wilderrodrigues thanks for review!
This PR apply on redundant networks, not redundant VR for VPC.
I tested it several times. you may get a result from my
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1198#discussion_r47202713
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2558,6 +2575,62 @@ public boolean res
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163539499
Hi @ustcweizhou,
I made a couple of comments in your code that would need addressing. Could
you have a look at that?
In addition, would you
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1198#discussion_r47201935
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2558,6 +2575,62 @@ public boolean
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1198#discussion_r47201591
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2558,6 +2575,62 @@ public boolean
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163329948
Sounds like a great improvement. Will test it!
Pinging @wilderrodrigues to have a look.
---
If your project is set up for it, you can reply to this ema
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1198
CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by
one
Testing results:
(1) before change:
job started at 2015-12-09 09:26:07,570, ended at 2015-1
22 matches
Mail list logo
