[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

2015-12-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1172#issuecomment-162043429 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

2015-12-04 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1172#discussion_r46670189 --- Diff: engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java --- @@ -1411,14 +1411,12 @@ protected void runInContext()

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1172#discussion_r46669997 --- Diff: engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java --- @@ -1411,14 +1411,12 @@ protected void runInContext()

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1172#issuecomment-161936477 LGTM (based on the code) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

2015-12-04 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1172 CLOUDSTACK-9107: Description of global config agent.load.threshold an… …d the actual behavior are not in sync Made configuration parameter description and behavior in sync. You