Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164416731
Have no infra to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164404825
@agneya2001 can you still lgtm this?
@maneesha-p thanks I am doing a quick verification install and if all ok
we are fine
---
If your project is set up f
Github user maneesha-p commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164396034
@DaanHoogland it was due to a latest change in the db file.Pushed
again.Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164387475
@maneesha-p @remibergsma had a go at it just before the creation of the RC
yesterday nigt but he encountered merge conflicts. Can you have e look? merge
with
Github user maneesha-p commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164347886
@bhaisaab @agneya2001 @DaanHoogland 2 LGTMs can it be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163940491
Elaborating on my LGTM: The changes are in right upgrade path. The sql
script is error free. It adds guest os support for 6.0 excluding the ones that
are depreca
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163930683
@agneya2001 please expand on *what* LGTY, the titel of the PR, the commit
message, your test results?
---
If your project is set up for it, you can reply to t
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163879896
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1216#discussion_r47322960
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -420,3 +420,7 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user maneesha-p commented on the pull request:
https://github.com/apache/cloudstack/pull/1159#issuecomment-163831485
@jburwell @DaanHoogland Raised a new PR(1216) with changes suggested .
@bhaisaab As master is in 4.7 we dont need the change in every upgrade path
before 4.6
GitHub user maneesha-p opened a pull request:
https://github.com/apache/cloudstack/pull/1216
CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0
Added suitable db entries in tables hypervisor_capabilities and
guest_os_hypervisor to support VMware 6.0 by copying from 5.5 and excludi
Github user maneesha-p closed the pull request at:
https://github.com/apache/cloudstack/pull/1159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1159#issuecomment-161927649
@maneesha-p It doesn't hurt to put this statement every where but let's
reduce the number of paths. as 4.6.0 to 4.6.1 contains a new view, I made a pr
to re-ro
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1159#issuecomment-161878161
@maneesha-p thanks for the PR, please fix as John suggests. We also support
vmware 6.0 on 4.5 branch, so do you think we need this in 4.5.2 to 4.5.3
upgrade path a
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1159#issuecomment-161876783
Master is now 4.7.0. Therefore, these database changes should be in
``schema-460to470.sql`` and ``schema-461to470.sql`` files.
---
If your project is set up for
GitHub user maneesha-p opened a pull request:
https://github.com/apache/cloudstack/pull/1159
CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0
Added suitable db entries in tables hypervisor_capabilities and
guest_os_hypervisor to support VMware 6.0 by copying from 5.5 and excludi
17 matches
Mail list logo
