Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163542373
@harikrishna-patnala This is reverted because of the lack of test report,
not the logic of your code. If you feel it must go in anyway please rebase the
code a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163537454
@wilderrodrigues it was merged before the freeze so I didn't revert it as
RM. But you are right about the not being tested.
---
If your project is set up for
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163536428
@bhaisaab
I thought only RMs would merge PR... isn't that so?
Plus, the PR was merged without one single person executing any test
against
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163283297
@wilderrodrigues can you have a look? you rmoved the code that is
reintroduced with this PR.
---
If your project is set up for it, you can reply to this email
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163140236
sorry guys, just notice it is already merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163140058
@DaanHoogland the fix is simple. We do not need special /extra process for
VPC routers.
@bhaisaab this issue does not exist in 4.5, as @koushik-das mentioned
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162472783
Thanks for picking this up, guys.
I still think there is calling code that should not be allowed to call
start twice. It should skip the VirtualNetwork
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162469279
@koushik-das good find, that means we also need to fix this for 4.6. We
would still need a round of tests just in case.
@harikrishna-patnala can you open a
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162468306
Actually I was looking at the history and this is what I found. This was
originally fixed with commit
commit e444a03819ccf72f61cb04e8428d20cc65b145e1
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162465934
@DaanHoogland let's revert, and ask @harikrishna-patnala to add more tests?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162464615
Guys, this got merged on only code review. No tests are described showing
the old and new behaviours. No unit tests are added. No regression tests are
added. I
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162434058
@koushik-das thanks, in that case LGTM.
Will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162418800
LGTM based on code changes.
@bhaisaab Since VpcVirtualNetworkApplianceManager is derived from
VirtualNetworkApplianceManager, start() call on both manag
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1140#discussion_r46256253
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -685,6 +685,16 @@ public void finalizeStop(final Virtua
GitHub user harikrishna-patnala opened a pull request:
https://github.com/apache/cloudstack/pull/1140
CLOUDSTACK-9094: Multiple threads are being used to collect the statsâ¦
CLOUDSTACK-9094: Multiple threads are being used to collect the stats from
the same VR
Same thread
16 matches
Mail list logo
