[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2016-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2016-04-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-212976859 We need to be doing this to more API calls, so I am happy we are starting to look at this. @DaanHoogland I don't think JSON adds much value here. I think the

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2016-04-21 Thread rajesh-battala
Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-212805433 Gone through the code. API change for the description param is good. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-175683694 LGTM anyone, needs one more? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-161205824 @anshul1886 It is a language independent description of the parameters and applicable to all API client implementations. It can also be view as a more generic/

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-161180226 @DaanHoogland I don't understand how json format is helping here? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160941315 There is two problems to solve here; 1. how to document the api in a concise way. The information you are providing is very useful and I think it makes sens

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160938583 @DaanHoogland Could you suggest a better way of putting this information in API documents in current scenario? --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160936999 It seems to me this text is only suitable for use with cloudmonkey or maybe python clients. I don't think it makes sense to format it this way in the java anno

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-12-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160908595 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

2015-11-26 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1126 CLOUDSTACK-9088: Update the description for migrateVirtualMachineWithVolume api https://issues.apache.org/jira/browse/CLOUDSTACK-9088 You can merge this pull request into a Git repository b