Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-160296576
sure, it was not meant as a -1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-160296533
@DaanHoogland This is already much better, when you have 30 port forwarding
rules the UI is unusable without this fix. When we want to make more
improvements, l
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158900212
I was wondering; as it seems obvious from your screenshot that initial
rendering works, after an item (i.e. row) has been added, whether it also
re-renders ok
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158898488
@DaanHoogland Is that what you mean.. testing it with the wider UI or..?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158874568
LGTM, haven't tested with resized UI though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158752938
@DaanHoogland resizing the screen? I didn't test that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158685974
less is more, if it works it's fine. How does it behave on resizing?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1081#issuecomment-158678341
Thanks for the fix @nitin-maharana. Tried it and it works great! LGTM
https://cloud.githubusercontent.com/assets/1630096/11320287/64aad05a-9094-11e5-90b8
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157498727
@nitin-maharana You can close this one. When the 4.6 one is merged, it will
be forwarded merged to master automatically.
---
If your project is set up for it,
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1081
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
For setting the width of each data item for each row of Port Forwarding
rules, it was processing all rules.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157440647
Hi @remibergsma
Actually 4.6 is nine commits behind this branch. So I am making one more
pull request with different branch. Thanks.
---
If your projec
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1080
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1080
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maha
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157409637
Hi @nitin-maharana thanks for the fix! Please make this pull request
against 4.6, so it can be fixed there as well. Once merged, it will be forward
merged to ma
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1076#discussion_r45074032
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
}
// Align width to main heade
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1076#discussion_r45052092
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
}
// Align width to main header
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1076
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
For setting the width of each data item for each row of Port Forwarding
rules, it was processing all rules.
19 matches
Mail list logo
