Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1075
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-158668313
LGTM, based on a set of tests that I run on this branch. Screenshot is from
an experimental Jenkins job (that runs the same tests I did manually until
now). The
Github user NuxRo commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1075#discussion_r45174353
--- Diff: packaging/package.sh ---
@@ -18,26 +18,37 @@
function usage() {
echo ""
-echo "usage: ./package.sh [-p|--pack] [-h|--h
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-157647291
As for installing the package, having distinct package version numbers
allows one to update packages instead of having to remove and install them in
succes
Github user davidamorimfaria commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1075#discussion_r45172947
--- Diff: packaging/package.sh ---
@@ -18,26 +18,37 @@
function usage() {
echo ""
-echo "usage: ./package.sh [-p|--pa
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-157643811
This is the package release version number, nothing to do with the thing
that is packaged.
Its purpose is to allow for this script to be used with
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-157638452
Quick question: were the generated packages installed successfully?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1075#discussion_r45169717
--- Diff: packaging/package.sh ---
@@ -18,26 +18,37 @@
function usage() {
echo ""
-echo "usage: ./package.sh [-p|--pac
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-157328375
LGTM
I did a centos63 build and it worked as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-157320397
code lgtm and my testing is the same as Davis so as I think we want a wide
range of users to have a go at this: @wido @remibergsma @resmo @karuturi @NuxRo
@bha
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1075#issuecomment-157133142
`package.sh -d centos7 -r 3`
(...)
`Wrote:
/root/cloudstack-packaging_release_version/dist/rpmbuild/RPMS/x86_64/cloudstack-management-4.6.0-SNAPSHOT
GitHub user davidamorimfaria opened a pull request:
https://github.com/apache/cloudstack/pull/1075
CLOUDSTACK-9065: Packaging RPM, add option for package release version,
cleanup and lint
In package.sh
* lint
* adjust exit codes (1 for usage, 2 for maven, 3 for rpmbuild)
12 matches
Mail list logo
