[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-216205142 @abhinandanprateek @agneya2001 please check that your changes has been merged on master and close this PR, thanks tag:closeme --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-175682672 @agneya2001 @abhinandanprateek please review and close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1117#issuecomment-160513890 Merging on 4.5, since the fix has been tested and merged on 4.6 --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-160513845 @remibergsma cool, @abhinandanprateek can you close this; as the other PR has been merged on 4.6 and will be fwd-merged on master to get the fix on master. --- I

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1116#issuecomment-160442050 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-160298327 If we want this in 4.6, please don't merge this. When #1116 is merged in 4.6, it will be fwd merged to master as well. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-159501138 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1116#issuecomment-159501130 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1117#issuecomment-159501118 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1117 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… https://issues.apache.org/jira/browse/CLOUDSTACK-9064 CLOUDSTACK-9064: The users should be ab

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1116 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… https://issues.apache.org/jira/browse/CLOUDSTACK-9064 CLOUDSTACK-9064: The users should be able to cre

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1115 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… …ared Networks in same Vlan ID, same Physical Network and same network, just with a different IP ranges. Yo

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek reopened a pull request: https://github.com/apache/cloudstack/pull/1113 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… Fix for https://issues.apache.org/jira/browse/CLOUDSTACK-9064 The users should be able to create mul

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1113#issuecomment-159411260 What about 4.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1113#issuecomment-159234061 LGTM (yet to test it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1113 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… Fix for https://issues.apache.org/jira/browse/CLOUDSTACK-9064 The users should be able to create multi