Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-172191471
@wilderrodrigues @remibergsma I stopped using xen at this point. Do I keep
this PR open. To me it is to much of a hobby project to invest in it atm.
---
If yo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1066#discussion_r45456092
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceData.java
---
@@ -0,0 +1,289 @@
+package com.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1066#discussion_r45450911
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceData.java
---
@@ -0,0 +1,289 @@
+package com.c
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157676447
@franklouwers like doing a review on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157671857
Ping @DaanHoogland @remibergsma @davidamorimfaria
Just finished some tests here. Based on the output + the code review I did,
this PR LGTM :+1:
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157634027
Building the environment to start testing this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157418520
No, we don't run any xen and I have to use spare time as a matter of
professional integrity when doing things on that platform. We don't have our
own bubble ye
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157417603
@DaanHoogland ... can't the guys at LeaseWeb help with testing against xen
or are you the only one with a bubble?
No need to close it due to test en
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157406551
@wilderrodrigues i have a habbit of -1'ing my own PR at times!
this time for instance. I ran this against the bubble and it failed. It was
the reason i
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157392000
Hi @DaanHoogland,
I run integration tests before creating the PRs and that's not manually and
I do have only 1 bubble. I just do:
* build c
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157303792
Wilder, I do run unit test always, but integration test only to the degree
that they make sense. Even then it is way more convenient to use the check-pr
script
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1066#discussion_r45030452
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java
---
@@ -55,10 +55,10 @@ public void u
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-157287092
Which automated tests? The ones in Travis that we cannot yet trust?
For the sake of review/feedback, that's valid. But concerning tests, we
also run
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1066#discussion_r45026523
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java
---
@@ -55,10 +55,10 @@ public voi
15 matches
Mail list logo
