Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157672288
@wilderrodrigues I'd be pleased to write a Marvin test though I've not
worked with them before. I think the first step would be to get the tests
running on my local
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157670606
Gave LGTM on #1062, extending it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157619773
Okay, understood.
I just read the other PR and saw your details about the tests, how you did
it, ando also saw that @remibergsma already tested the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157421231
@wilderrodrigues I want to merge this to 4.6, so the one against master
should be closed. As we merge forward now, we need bug fixes against 4.6.
Otherwise it w
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157416663
@wilderrodrigues no, i was asked to open this pull request by @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157416121
Should it be closed then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157411634
This is a duplicate of PR https://github.com/apache/cloudstack/pull/1062
---
If your project is set up for it, you can reply to this email and have your
reply appea
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1079
CLOUDSTACK-9058 - Respond with "saved_password" if no password is to be
issued.
The password server on the virtual router should respond with
"saved_password" if no password is to be issued. T
