[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2016-01-17 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2016-01-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-172326528 discussions to dev@ as indicated by @jburwell . this PR losts its purpose. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2016-01-16 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-172203787 @DaanHoogland I lost track of the mailing list thread until this PR. In summary, I am -1 on the use Optional based on past experiences. Please see my [response](

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2016-01-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-172191244 pinging possibly other interested parties @jburwell @wido @jlk @bhaisaab I think we want to use the java optionals instead but interested in opinions on th

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-12-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-162339782 @rafaelweingartner we still allow for 1.7 so no 1.8 only features for now --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-11-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-159127168 I would rather use Java 1.8. We are already migrating to Java 8, right? --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-157415551 tnx @remibergsma . It can be merged but more important is for it to be a coding policy so I'll link it on dev@ @miguelaferreira Or should we consider going

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-157411442 @DaanHoogland FYI test results: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-11-11 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1060 CLOUDSTACK-9054 use of google-optional as PoC this is using guave optional as suggested by @miguelaferreira in #1056. I am not convinced it is appropriate for that case (as opposed to thro