[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1089 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1089#issuecomment-158338131 @DaanHoogland the tests succeed for me: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true smoke/test_ss

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-19 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1089#issuecomment-158144546 Before merge, I want to retry the two failed tests and see if they work for me. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-19 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1089#issuecomment-158141395 [1088.test_network.results.txt](https://github.com/apache/cloudstack/files/39300/1088.test_network.results.txt) [1088.test_vpc.results.txt](https://github.

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-19 Thread jlk
Github user jlk commented on the pull request: https://github.com/apache/cloudstack/pull/1089#issuecomment-158127621 LGTM, thanks Daan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-18 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1089#issuecomment-157899791 Assuming Jenkin passes, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-18 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1089 CLOUDSTACK-9053 security upgrade as per COLLECTIONS-580 cloustack is not vulnerable but as the classes are in they might be used in the future so we upgrade to prevent accidental

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1088#issuecomment-157887108 should have been against 4.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-18 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9053 security upgrade as per C...

2015-11-18 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1088 CLOUDSTACK-9053 security upgrade as per COLLECTIONS-580 cloustack is not vulnerable but as the classes are in they might be used in the future so we upgrade to prevent accidental