Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1046
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155378548
Ping @remibergsma @borisroman
This PR LGTM :+1:
I reviewed the code and read the comments in the PR, also looking at the
tests @borisroma
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155218538
I added a RBD pool using the ZoneWizard:
Github user kevindierkx commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155012289
The code looks fine to me.
@DaanHoogland @borisroman I agree decoupling the UI from the main
Cloudstack project would be the better choice. Development
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155010677
I will have a chance to test it this week
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155004057
@davidamorimfaria If we need to reinstoll a devcloud this week, can we
verify as well?
---
If your project is set up for it, you can reply to this email and h
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-155001934
@DaanHoogland @borisroman Fully agree, the UI is currently not the best,
but this change can go in.
I want to LGTM, but it's hard to test. The code seems fine
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-154862003
@DaanHoogland I share the same opinion. I would actually like to see the UI
be a separate project. But in my opinion that supersedes this PR.
---
If your projec
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1046#issuecomment-154860964
though this is a needed change, would we want to solve it more generally so
there will be only point of maintenance?
---
If your project is set up for it, you
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1046
CLOUDSTACK-9044: Add RBD Primary Storage to the Zone Wizard.
Added to option to use RBD as primary storage in the Zone Wizard.
Pure UI change.
You can merge this pull request into a
12 matches
Mail list logo
