[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155082318 ok, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155080030 @resmo After 4.6 we should then make a PR to remove all old bash scripts from the repo. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155078020 @remibergsma since this buggy script is still there in master branch we should IMHO either merge this PR or remove the script from master branch. Remove it? --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155055433 @resmo Can you please close this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154446597 @resmo That's all fine, glad you took the time to submit this. You may want to send the same PR against 4.5, as it is definitely relevant there. And, m

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154436021 @remibergsma okay, never mind for false alarm then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154430267 @resmo @ustcweizhou This script is not used in 4.6 I'd say. There is a python class called CsDhcp.py that handles this. --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154426348 @remibergsma @ustcweizhou updated and rebased the patch with some more fixes... --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154414891 @ustcweizhou seeing some more potential problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154404851 FYI: Started tests on this branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154398072 LGTM btw, can you check other part except hostname in the file and fix them too? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1042 CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties in /etc/dhcpentries.txt we had: 02:00:1e:07:01:53,set:10_102_92_5,10.102.92.5,songlog-1,infinite 02:00:0b:a2:00:3d,set:10_102_9