Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1029#issuecomment-153680788
LGTM +1 (just code review, no testing was performed)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1029#issuecomment-153669733
Seems good! Great to see this :) Some tests are failing though, could you
look into that?
---
If your project is set up for it, you can reply to this email and have y
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1029#issuecomment-153634024
@koushik-das Thanks for your comments. I pushed a new commit .
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1029#discussion_r43848708
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -672,6 +672,7 @@
"86400",
"The interval (in seconds)
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1029#discussion_r43844404
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -420,3 +420,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1029#discussion_r43844351
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -672,6 +672,7 @@
"86400",
"The interval (in seconds)
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1029#issuecomment-153467987
Excellent! I thought this feature was already implemented via
expunge.delay, good to know it doesn't work as I thought it was.
---
If your project is set up for it,
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1029
CLOUDSTACK-9022: keep Destroyed volumes for sometime
for now, the Destroyed volumes will be expunged in Storage cleanup thread,
no matter when they are destroyed.
In Expunging vm thread
