Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152286968
Agree that the Jenkins failure is unrelated. Will soon merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152264912
@remibergsma @wilderrodrigues Also ran the test against PR #981 => LGTM
:+1:
```
=== TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152220381
It says test failures 0. I have no idea why it's red! In addition, no Java
code was changed!
 with any testing / verification you did. We need 2 LGTMs
before we can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152203550
LGTM
Run this:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
test/integration/component/t
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1002#discussion_r43389852
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152194820
@wilderrodrigues Testing this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152189749
@remibergsma @karuturi
All green... Do you have some time to review/merge this PR? It's a test, no
code - neither on the routers nor the java side
Github user serbaut commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1002#discussion_r43384431
--- Diff: test/integration/component/test_router_dhcphosts.py ---
@@ -0,0 +1,381 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user serbaut commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152180011
Thank you, that would have taken me days to write.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152127063
Ping @serbaut
I just executed the test against Master and got the following error:
```
cat /etc/dhcphosts.txt | grep 10.1.1.50 | sed 's/
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152122575
Ping @remibergsma @DaanHoogland @karuturi @bhaisaab @serbaut @borisroman
Test results
* Management Server + MySQL on CentOS 7.1
* One K
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1002
CLOUDSTACK-9007 - Write test to check that the /etc/dhcphosts.txt doesn't
contain duplicate IPs
This PR contains a test that will cover the fix on PR #981
The tests does the f
14 matches
Mail list logo
