[GitHub] cloudstack pull request: CLOUDSTACK-9004: Add features to HyperVEn...

2015-10-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1013#issuecomment-152724047 @jharshman Very clear Josh. This would be for 4.7 then. based on review you have my LGTM. We will need to run a test suite before merging but let's wait as it

[GitHub] cloudstack pull request: CLOUDSTACK-9004: Add features to HyperVEn...

2015-10-30 Thread jharshman
Github user jharshman commented on the pull request: https://github.com/apache/cloudstack/pull/1013#issuecomment-152675128 My apologies Daan, I am happy to clarify. The PR for this Jira ticket (9004), was created as a subtask of CLOUDSTACK-8978. It's intent is to add the

[GitHub] cloudstack pull request: CLOUDSTACK-9004: Add features to HyperVEn...

2015-10-30 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1013#issuecomment-152667236 I can see that your code does what you say in the description @jharsman but I totally lack the background in windows to judge whether this make sense. Can you

[GitHub] cloudstack pull request: CLOUDSTACK-9004: Add features to HyperVEn...

2015-10-30 Thread jharshman
GitHub user jharshman opened a pull request: https://github.com/apache/cloudstack/pull/1013 CLOUDSTACK-9004: Add features to HyperVEnlightenmentFeatureDef Add function to set vapic, spinlock and retries Add function to get retry value Modify toString to output appropriate XML