Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151953800
@wilderrodrigues Ok! Code LGTM :+1: @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151953539
@borisroman and @remibergsma, the 2 commits have been squashed.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151952219
@borisroman: the fix typos can be squashed and the one that says "use
correct ip address" as well, the other two won't because they are independent:
1 for th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151944891
@remibergsma The comments I placed are fixed in
50827f7e4ba90e2cbf163a9946c84d1835630ead. Though this introduces my new
comment; can the commits be squashed? As t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151936598
@borisroman Can you please review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151936406
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151782444
Ping @remibergsma @borisroman @karuturi @DaanHoogland @miguelaferreira
@michaelandersen
Test results:
* Hardware required: false
* Manag
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151735882
Test results:
* Hardware required: true
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs b
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/989#discussion_r43184165
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -602,9 +610,8 @@ def compare(self, bag):
if self.dev in b
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/989#discussion_r43184047
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -602,9 +610,8 @@ def compare(self, bag):
if self.dev in b
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151628960
Ping @remibergsma @karuturi @DaanHoogland @bhaisaab @miguelaferreira
@michaelandersen
Test environment:
* ACS built from source
* Manage
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/989
CLOUDSTACK-8991 - IP address is not removed from VR even after disabling
static NAT
This PR fixes the Public IP removal form the virtual routers. It also
improves the existing test_netw
13 matches
Mail list logo
