Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1320#issuecomment-216220179
@nitin-maharana please rebase and share screenshots of what this fixes
A manual UI testing would be needed
---
If your project is set up for it, you can repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1320#issuecomment-215554347
@nitin-maharana please rebase as we currently have merge conflicts.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1320#discussion_r52106924
--- Diff: ui/scripts/instanceWizard.js ---
@@ -294,53 +295,67 @@
// Step 3: Service offering
function(args) {
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1320#issuecomment-169931271
Reference PR #1150 (Against 4.6). This PR (against 4.7) contains the same
code change with one conflict which I resolved.
---
If your project is set up for
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-169931078
Closing this PR as made a new PR #1320 (Against 4.7 which will be merged in
master later).
---
If your project is set up for it, you can reply to this email
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1320
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
A new icon over VM snapshot object, which
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-168136764
Sorry I have no vmware setup to test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-168115562
@remibergsma : Any updates on this? Can you please look at the change if
you have a setup. Thanks.
---
If your project is set up for it, you can reply to th
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-168075565
@nitin-maharana sorry don't have the infra to setup vmware and test right
now, so cannot help test it
---
If your project is set up for it, you can reply to this
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-167931844
cc @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164514502
Step-1:
=
Ste
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164477318
@DaanHoogland sorry missed your message, I did not test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164279018
@bhaisaab did you test this? should we merge before the RC tonight?
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164178250
@nitin-maharana @bhaisaab both I and @remibergsma don't work with vmware as
part of our cloudstack installs, can you do testing and preferably write tests
for
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162612180
@bhaisaab @DaanHoogland I updated the change with current 4.6 branch and
removed the commented codes. @remibergsma This only supports in VMware. Thanks
:)
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162485224
Hmm.. this isn't supported on KVM, is it? That may be why I can't find it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162484701
@nitin-maharana @bhaisaab I looked around but just don't find what's
changed. Please post screenshots of what is changed or instruct exactly how it
should work.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162416679
@nitin-maharana if you can address what Daan has commented today, along
with fix tabs with spaces (if any) I can help review this and merge this;
before 4.7.0/mast
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
--- Diff: ui/scripts/instanceWizard.js ---
@@ -731,25 +746,33 @@
//step 1 : select zone
$.extend(deployVmData
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-161262674
Made a pull request to merge in 4.6. So closing this PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/953
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1150
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
A new icon over VM snapshot object, which
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-150837653
Sure @remibergsma I will do that. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-150836024
Hi @nitin-maharana can you please rebase with current master? I'd like to
test your patch. Thanks!
---
If your project is set up for it, you can reply to this e
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/953
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
A new icon over VM snapshot object, which u
26 matches
Mail list logo
