Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162450640
@snuf
The procedure getCommandHostDelegation are overrided in three hypervisor:
XenserverGuru, VmwareGuru and Ovm3HypervisorGuru.
We should make su
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162448978
Seems like we have the same problem in the XenServer code, as I stated
earlier in another pull request somewhere out there, where this code originates
from (XenServerG
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162337123
lgtm, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162331667
@snuf are you, as the author of the ovm3 hypervisor plugin, alright with
this?
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162331595
lgtm, but can you squash these commits to no longer include a revert,
@ustcweizhou ? thanks
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162286584
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162107478
Pinging @snuf to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162067636
The diff between this PR and last commit (before 4.6)
```
# git diff 2e26e97fe87cfc68a1748d6d5e539cd60cff22b2
plugins/hypervisors/ovm3/src/main/java/com/
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1177
CLOUDSTACK-8964: Ovm3HypervisorGuru handle only srcData with HypervisorType
is Ovm3
This PR can only be applied after PR #1176
The CopyCommand on Ovm3 should be handled by Ovm3Sto
10 matches
Mail list logo
