Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-152290121
based on code review LGTM. @nitin-maharana makes sense to write a marvin
test for this. could you?
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-150780723
@nitin-maharana Thanks! LGTM, based on a set of tests that I run on this
branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-150112575
Sure @remibergsma. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-150032717
@nitin-maharana Can you force push your commit again so the tests can run
again? If they fail again, please have a look why.
---
If your project is set up for i
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/945
CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong
to non-dedicated account
Earlier the deployment planner was not handling the case of virtual
routers.(In E
