Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/938#issuecomment-222551754
### ACS CI BVT Run
**Sumarry:**
Build Number 91
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_L
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/938#discussion_r61725650
--- Diff: engine/api/src/com/cloud/vm/VirtualMachineManager.java ---
@@ -55,6 +55,9 @@
static final ConfigKey VmConfigDriveLabel = new
ConfigKey("H
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/938#issuecomment-216198287
@kansal please rebase against master and push -f, and update on status of
your PR, thanks
---
If your project is set up for it, you can reply to this email and have y
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/938#issuecomment-183965957
Ping @kansal. Could you take a look at @pedro-martins's and
@GabrielBrascher's suggestions? They seem worth it to me... Also, if you do,
please go ahead and reb
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/938#discussion_r49919875
--- Diff: engine/api/src/com/cloud/vm/VirtualMachineManager.java ---
@@ -49,12 +49,15 @@
public interface VirtualMachineManager extends Manage
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/938#issuecomment-172103324
Hi.
There is no problem to set vmData to null? and what about replace this
short if to a method with documentation and a little test.
And if you extrac
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/938
CLOUDSTACK-8959: Option to attach the config drive.
Config Drive was added as a part of DNS/DHCP offload feature. The main aim
was to provide a way to send user data to VM instances in case of no
