Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/931
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-148107806
@wilderrodrigues based on below results LGTM.
```
echo "Running tests with required_hardware=true"
nosetests --with-marvin --marvin-config=${marvi
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-148070945
Thanks, @karuturi !
Will push a new PR today with more fixes. This time for the redundant VPC.
Cheers,
Wilder
---
If your project is se
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-148048131
Hi @wilderrodrigues
I ran all the tests in smoke folder(BVT) on a setup with 2 xenserver 6.5
hosts in advanced zone.
All the tests passed except the below (
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-148001804
@wilderrodrigues I will build and run it soon. Will post results later
today or tomorrow, depending on when it's done. Thanks!
---
If your project is set up for
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147993624
code LGTM, few small remarks. (Probably won't have/make time to run a test
before the others:()
---
If your project is set up for it, you can reply to this ema
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41973826
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -254,30 +255,30 @@ def test_01_create_lb_rule_src_nat(self):
)
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147990778
Thanks @wilderrodrigues. I will run the tests tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41972411
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py ---
@@ -150,6 +150,8 @@ def compare(self, list):
new_rule
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147988545
LGTM (not tested). Just fix the test to use a for x in range(5) and break
if unameResults are not None.
---
If your project is set up for it, you can reply to this
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971855
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -254,30 +255,30 @@ def test_01_create_lb_rule_src_nat(self):
)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971913
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -371,22 +372,22 @@ def test_02_create_lb_rule_non_nat(self):
"Check List Load
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971893
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -371,22 +372,22 @@ def test_02_create_lb_rule_non_nat(self):
"Check List Load
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971547
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py ---
@@ -150,6 +150,8 @@ def compare(self, list):
new_rule.se
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147986130
Hi @remibergsma @karuturi @wido @borisroman @DaanHoogland @miguelaferreira
@bhaisaab
* Environment for required_hardware=true
* Management Ser
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/931
CLOUDSTACK-8947 - Load Balancer not working with Isolated Networks
This PR fixes the Load Balance feature by adding iptables rules for the
public IP and port of the LB.
In order
16 matches
Mail list logo
