Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-151184193
@remibergsma @bhaisaab we could merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-151184063
ran nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_ro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-150938750
ok, so
if (destpool == null) {
throw new CloudRuntimeException("missing storage pool");
}
or something like that? Or would you rather see a Nu
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-150917120
@DaanHoogland good point. I prefer to throw an exception if the pool is
null.
---
If your project is set up for it, you can reply to this email and have your
re
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/918#discussion_r42943657
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1763,7 +1763,7 @@ private void orchestrateStorageMigration(fin
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-148430139
I am running 932 now and will run this one after that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-148146012
@DaanHoogland We shouldn't merge without running some functional tests. Can
you run some please?
---
If your project is set up for it, you can reply to this ema
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-148038282
LGTM indeed! @remibergsma and @karuturi can you please merge this one in
your next batch?
---
If your project is set up for it, you can reply to this email and
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-147089251
@ustcweizhou can you do a push again to force travis/jenkins to re-run.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-147089236
LGTM. Looks like jvm crashed while building the maven cloud-server
project/module.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-147077287
@ustcweizhou Can you look at the jenkins error?
Something very serious happened in this build
Running org.apache.cloudstack.networkoffering.CreateNe
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/918
CLOUDSTACK-8941: fix NPE when migrate vm to other zone-wide pools the
second time
This is because the pod_id is set to NULL at the first time when I migrate
the instance to a zone-wide pool
13 matches
Mail list logo
