Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-153012703
LGTM :+1:
Please proceed with merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152581514
@wilderrodrigues any update on your review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152449289
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152441332
Ping @remibergsma @karuturi @kansal
I will run the hardware required tests as well and try to deployed a VM
with a shared network.
Partial
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152411793
Hi @wilderrodrigues, To check the bug is solved, try deploying the VM in
shared network with no service.
https://cloud.githubusercontent.com/assets/4276209/1
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152290835
code lgtm @remibergsma can you retest? A newer commit is in since your lgtm
---
If your project is set up for it, you can reply to this email and have your
repl
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152196235
Hi @kansal
Should I deploy a basic zone with shared network in order to see if that
fix is fine?
I will also run the other set of tests, s
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152152422
@remibergsma @bhaisaab The above changes were made as the part of DHCP/DNS
offload feature. The related ticket is
https://issues.apache.org/jira/browse/CLOUDSTACK-832
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-151500654
@ remibergsma Thank you very much. I was busy somewhere. Will update this
PR with "update script" and rebase it. Sorry for the delayed response.
---
If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-151475559
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-150948753
Hi @kansal Can you please rebase this with current master? I tried running
some tests but face old problems. Also, what about the db migration script to
fix old
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-147384308
Use db migration from either past 4.5.x to 4.6.0 version, or this PR gets
merged post 4.6.0; add the data migration code in 4.6.0 to 4.6.1
---
If your project is s
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-147295409
@bhaisaab Sure will check about the back-porting of the issue. Apart from
that, the previous values stored incorrectly need to be corrected in the
database. I think a
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-147089352
@kansal LGTM.
Looking at the JIRA issue, this looks like should apply to 4.6/master but
can you update the ticket with the version details, more details on
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-146813771
So several questions:
1. What versions of ACS does this affect?
2. What tests were failing (if any)?
3. What tests need to be added so we don't have a regr
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/916
CLOUDSTACK-8940: Wrong value is inserted into nics table netmask fielâ¦
â¦d when creating a VM - Fixed
Problem: When creating a VM in shared network with no service, the value of
netma
17 matches
Mail list logo
