[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-153083572 Thanks @karuturi @remibergsma. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/903 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-153009144 Nice small fix, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-152994809 great find @nitin-maharana manually tested the fix In my setup, I had a vm with two nics isolated1 - 10.1.1.14 - default isolated 2 -

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-10-30 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-152456961 Hi @runseb @remibergsma I don't understand how to write a test for this. If you have any idea of how to write one, please help me out. Thanks. --- If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-10-24 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-150840976 @remibergsma I was busy in some other works. Within 3-4 days I will work on this and will give an update. Thank you. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-10-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-150838491 @nitin-maharana Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-10-07 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-146101066 @runseb I think there is no automated tests for this. I will try to write one. Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-10-05 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-145662476 @nitin-maharana Any automated tests for this ? if not, can you spend the time to write some. thanks --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-10-01 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/903 CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being created While calling the listNics API, inst