[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-216194918 @yvsubhash please rebase against latest master and push -f, update on status of your PR tag:easypr --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-175671692 Ping review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2015-10-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-150838644 @michaelandersen can you please review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-147089792 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2015-10-06 Thread yvsubhash
Github user yvsubhash commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-146090133 License Added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2015-10-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-145926015 @yvsubhash Please fix the license in this file: engine/schema/test/com/cloud/usage/dao/UsageStorageDaoImplTest.java --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2015-09-28 Thread yvsubhash
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/896 CLOUDSTACK-8908 After copying the template charging for that template is getting stopped This is happening as the zone id is not part of the query. Zone id is added to the query and unit tes