Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/883
### ACS CI BVT Run
**Sumarry:**
Build Number 103
Hypervisor xenserver
NetworkType Advanced
Passed=71
Failed=2
Skipped=3
_Link to logs Folder (se
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-220513693
Can someone with a xenserver setup validate this one? @bvbharat can you
queue this one up for us? Thanks...
---
If your project is set up for it, you can reply to t
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-216194579
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-212742630
The existing implementation for logrotation that works with xenserver 6.0
and earlier does not works with 6.0.2 and later. That is the reason I have
added this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-212537408
I will admit, I don't really understand everything in play here. If I read
this quickly, it seems like this PR may not be needed because #861 essentially
changes the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-212471834
@SudharmaJain Will @swill is the RM for master/4.9, I'm not following these
changes perhaps any Xen guru can comment, @agneya2001 ?
@remibergsma do you have any
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-212404120
@bhaisaab Rebased the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-175671185
@SudharmaJain Please rebase and send for a re-review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/883#discussion_r43846616
--- Diff: scripts/vm/hypervisor/xenserver/logrotate ---
@@ -0,0 +1,29 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) unde
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-153051565
Hi @SudharmaJain can you please fix the conflict? I'll then run some tests
and we're ready to merge.
---
If your project is set up for it, you can reply to this
Github user sspans commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/883#discussion_r43131260
--- Diff: scripts/vm/hypervisor/xenserver/logrotate ---
@@ -0,0 +1,29 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-151047344
Changes LGTM. I haven't tested it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-150820547
@sspans Can you review this xenserver logrotate change please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-150033996
@koushik-das Any update on this please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-148945004
@koushik-das I merged #861 and @SudharmaJain updated this PR and removed
the reimplementation of XenServer 6.0.2 resource. Are you OK with this change
now? Pleas
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-147233273
@remibergsma @koushik-das I have made the changes and have removed
reimplementation of XenServer 6.0.2 resource. I have added changes to patch
file for XenServe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-147112896
We won't merge this PR, we should merge #861 instead. Final call to
@SudharmaJain to confirm if PR #861 also fixes your issue. If I do not get a
response in the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-147090189
LGTM (code-wise), let's merge this once tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-146093740
@SudharmaJain Please test PR #861 and confirm your problem has been solved.
We'll then close this PR and merge the other.
---
If your project is set up for it,
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-146083023
@remibergsma @koushik-das For incorporating the change in
XenServer600Resource, I need to test the change for Xenserver 6.0. After
checking it for 6.0, I will
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-146081053
@koushik-das This bug exist in xenserver 6.0.2 and later. For XenServer
6.0, logrotation works. Thats is the reason i have implemented
XenServer602Resource and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-145157098
@SudharmaJain Please respond to comments. If you agree, please close this
PR. Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-144347154
@SudharmaJain Why can't the XenServer600Resource be used to handle XS 6.0.2
hosts? The only change I see is the patch script
(scripts/vm/hypervisor/xenserver/xen
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-143645025
@remibergsma Rebased against the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-143590005
@SudharmaJain Can you please rebase against current master? Then we can run
the tests.
---
If your project is set up for it, you can reply to this email and hav
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-143478261
@remibergsma I didn't checked the PR #861. I was looking to fix the issue
with xenserver 6.0.2 and higher. For this I have added a logrotate script and a
Patch
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-143475690
@SudharmaJain The title and the content of your PR do not match. You seem
to re-implement the XenServer 6.0.2 resource? If that is what you want, make a
PR just
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/883
CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver
After integrating XS with CCP the following folder gets created:
/var/log/cloud/ however the logs in that are not rotate
28 matches
Mail list logo
