Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218356820
These connectivity issues are unrelated to this PR. I will merge this
now...
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218356736
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 3
Errors: 0
Duration: 6h 24m 57s
```
**Summary of the pr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218004558
Thanks @koushik-das. I will run this through CI just to be sure everything
is good... Thx.
---
If your project is set up for it, you can reply to this email and hav
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-217809810
@swill This has the required LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-216847988
LGTM. Verified that a configuration entry is added with default 8 as pool
size. Increased the default threadpool size, restarted MS and verified that
when multip
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-216325329
We need another code review. How should I test this, does it have to be a
manual test?
---
If your project is set up for it, you can reply to this email and have you
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-216194476
LGTM
tag:easypr
Cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-212724576
@bhaisaab I pushed it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-212474909
Thanks @SudharmaJain LGTM (just code review), can you do a push -f (travis
job failed for some reason)
---
If your project is set up for it, you can reply to this
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-212418415
Rebased against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r41722125
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,4 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
UNIQUE KEY `uk_ldap_trust_map__domain
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-147090210
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r41697322
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,4 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
UNIQUE KEY `uk_ldap_trust_map__domain_id`
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40756846
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,6 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
UNIQUE KEY `uk_ldap_trust_map__domain
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40658531
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,6 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
UNIQUE KEY `uk_ldap_trust_map__domain_
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40658483
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -278,6 +278,8 @@
@Inject
private EndPointSelector selector;
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40543530
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -1999,7 +1999,9 @@
// StatsCollector
StatsOutPutGraphiteHost("Advanc
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40532523
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -1999,7 +1999,9 @@
// StatsCollector
StatsOutPutGraphiteHost("Advance
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/880
CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads
The thread pool was hardcoded to use 8 threads,
com.cloud.template.TemplateManagerImpl.configure(String, Map):
20 matches
Mail list logo
