[GitHub] cloudstack pull request: CLOUDSTACK-8897: baremetal:addHost:make h...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/874#issuecomment-216193842 @harikrishna-patnala please rebase against latest master and push -f, update on status of your PR LGTM tag:easypr --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-8897: baremetal:addHost:make h...

2016-02-14 Thread alexandrelimassantana
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/874#discussion_r52846753 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -680,6 +680,13 @@ public Discoverer getMatchingDiscover(final Hyperv

[GitHub] cloudstack pull request: CLOUDSTACK-8897: baremetal:addHost:make h...

2015-09-30 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/874#issuecomment-144332355 We won't be able to test this on simulator. @harikrishna-patnala can you answer @borisroman and then we can merge. LGTM +1 on code review alone --- If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-8897: baremetal:addHost:make h...

2015-09-22 Thread harikrishna-patnala
GitHub user harikrishna-patnala opened a pull request: https://github.com/apache/cloudstack/pull/874 CLOUDSTACK-8897: baremetal:addHost:make host tag info mandtory in bar… CLOUDSTACK-8897: baremetal:addHost:make host tag info mandtory in baremetal addhost Api call addhost