Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-167753605
@sanju1010 it shouldn't be in the same file then, or the file should be
renamed to a more generic name
---
If your project is set up for it, you can reply to
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-167752950
@DaanHoogland / @remibergsma can you please merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-167752857
It is not type Daan. First test inside TestAttachDataDisk class tests some
functionality on ZWPS and this one is for CWPS.
Test Results :
Attach Data D
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/869#discussion_r48475788
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -207,3 +208,188 @@ def test_01_attach_datadisk_to_vm_on_zwps(self):
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-167551878
I did a code walk-through and looks good.
LGTM !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-166888961
@pvr9711 Where is your LGTM based on? I'd like to see some background, as
otherwise we don't know what you tested / reviewed.
---
If your project is set up for
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-166880339
@runseb, this cannot be run via simulator.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-144331549
@pritisarap12 can this be run via simulator ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/869
CLOUDSTACK-8895: Verify if storage on storage pool can be attached to VM
Test case to verify if data volume uploaded in a storage pool(Cluster wide
storage pool) is available for attachment
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-142205006
Test case result:
Attach Data Disk on CWPS To VM ... === TestName:
test_01_attach_datadisk_to_vm_on_zwps | Status : SUCCESS ===
ok
11 matches
Mail list logo