[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/860 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151214062 Ping @karuturi @remibergsma ... time to get this on in? :) Cheers, Wilder --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096712 3rd attempt. I hope it succeeds this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096159 @karuturi Jenkins failed; [ERROR] Error in Cobertura Report generation: Unable to execute Cobertura. Could maybe force push again? --- If your p

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151089307 @remibergsma @karuturi I tested this PR with the changes in #979. Results: ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-k

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151047752 @borisroman yes this is real :) . I think this might exist in 4.5 as well. Haven't tested it there. I rebased with the current master --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-150681274 @karuturi @remibergsma Is this still actual? If so, could you please rebase? I'll then test it and it can be a bugfix for 4.6 :) --- If your project is set up fo

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-09-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-142174642 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-09-21 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/860 CLOUDSTACK-8889: delete volume doesnt decrement primary store resource count Primary Storage count for an account does not decrease when a Data Disk is deleted belonging to the account unles