Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/864
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-173197587
Ping @remibergsma @borisroman
Please, make it happen! :)
Cheers,
Wilder
---
If your project is set up for it, you can reply to this em
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/864#discussion_r47128468
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmU
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/864#discussion_r43605651
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUuid,
f
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-152940799
@wido,
sorry for the late response, was busy with other work. I have replied to
your question inline.
@remibergsma
Thanks for taking time and te
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/864#discussion_r43601603
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUui
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-151993447
@bvbharatk we are almost ready to merge. Could you please respond to the
comment made by @wido? Thanks!
---
If your project is set up for it, you can reply to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-151993024
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-150838798
@bvbharatk Can you please rebase this against current master so I can run
some tests? Let mw know if you need help!
---
If your project is set up for it, you ca
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-147112744
Once rebased we can run tests, otherwise we will find false positives.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-147090446
LGTM, you rebase against latest master @bvbharatk and reply to Wido's
comment. Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-143589960
@bvbharatk Thanks! Can you please rebase against current master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/864#discussion_r40195974
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUuid,
f
GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/864
CLOUDSTACK-8860: improve error messages in VM deployment code path.
improved the error messages in vm deployment code path. added some more
data to the error messages and also fixed some error
14 matches
Mail list logo
