[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-216190239 @bvbharat please rebase against latest master and push -f, update on status of your PR also, how do we test your changes --- If your project is set up for it

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213430064 @bvbharatk no problem. :) Thanks for the continued effort testing. I just wanted to make sure we understood what was going on. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213424108 @swill This is because of a problem with the CI environment. i will fix this and post the results again. Will remove these results for now. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213422548 I am a bit concerned about this CI run. There is a LOT failing which does not usually fail. We will need to review the CI results and try to understand/fix the probl

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213395917 ### ACS CI BVT Run **Sumarry:** Build Number 3 Hypervisor xenserver NetworkType Advanced Passed=69 Failed=19 Skipped=3 _L

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-20 Thread bvbharatk
Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r60530964 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final CancelMaintenanceCmd cm

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-20 Thread bvbharatk
Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r60529246 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -971,33 +971,28 @@ public Answer easySend(final Long hostId, fin

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-02-05 Thread rodrigo93
Github user rodrigo93 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r52094072 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final CancelMaintenanceCmd cm

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-02-05 Thread rodrigo93
Github user rodrigo93 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r52093680 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -971,33 +971,28 @@ public Answer easySend(final Long hostId, fin

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140745806 @bvbharatk Any advise on how to test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140646781 @wilderrodrigues my bad, something went wrong while creating the pr. fixed this. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140645828 Why do we have 2 PR with the same issue/branch/description, @bvbharatk ? I check the PR #838 and that's about something else. Could you please edit the PR de

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/838#issuecomment-14064 Which steps should we follow to test it, @bvbharatk ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/838 CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. earlier we were eating up exceptions from the lower layer which resulted in improper error messages. fixed p

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/837 CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. earlier we were eating up exceptions from the lower layer which resulted in improper error messages. fixed p