[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-10-02 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/829 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-10-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-144949845 This change will have to go in a more solid and complete refactor, probably in smaller steps. The fix it is intended for will go in #885. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142940617 So I made a new PR #885 as a replacement for new discussion how this issue can be solved. IMHO this PR can be closed --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142920071 I have followed your explanation but what I am trying to say is that it may get updated due to side effect of some other code as from my experience this was worki

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142912573 Cloud you follow my explanations? If this would help, I must set the ping interval to a year or somewhat identical. Are you REALLY followed my explanations? What did I

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142909650 Yes, increasing time should help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142906721 This is perfectly clear to me. The problem is we are relaying on the `update_time` (not to mix up with `power_state_update_time`). ~~~

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142901959 Increasing the grace period for a few minutes won't help. If you look at these update_time values I queried from 10 running routers, you see these are days, weeks behi

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142903425 This simply means that there power_state has not changed for that period of time. As I pointed out in my previous comment that if state is consecutively updated w

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142899514 From code it seems to be getting updated and DB also suggests that. It will not be updated if there is no power change for MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142882541 @anshul1886 @koushik-das @DaanHoogland and I had a debug session last friday, and since he is off for the next couple of days I can give you more details about w

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141613687 @DaanHoogland what update_time are you talking about? I think as a work around increasing ping interval to some higher value like 90 sec or 120 seconds in glo

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141482058 @koushik-das @anshul1886 the grace period is not going to work. updat_time is not getting updated. We really need to fix the statemachine --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141421211 @koushik-das about the bug probably not being in 4.6 i agree. @resmo I understood that the router was rebooted while you set the reboot on out of band flag t

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141418450 @DaanHoogland As per logs attached in bug VR reboot happened due to out-of-band movement from one host to another and not due to power report missing. H

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141407138 @koushik-das @DaanHoogland unless we have a "better" solution I would like to go with @anshul1886 suggested fix. It seems the best way not breaking anything else.

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141403050 @koushik-das I am perfectly fine with not putting this code in but I don't understand that you don't follow how it is related to the bug reported. The logs supp

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141377920 -1 to this PR as I am not able to follow how the change is related to the bug. Also this is going to impact any HV having VM changes outside of CS like Vmware an

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141050957 If @remibergsma is right then the design is really broken. two events come in during migration: # PowerOn (or Off or what ever is actual) # PowerReportMi

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140983520 @resmo You're right and I wasn't clear enough I guess. Because I think the 'PowerReportMissing' comes from the VM on the hypervisor that you are migrating _to_,

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140879864 @remibergsma does not look related to me, the keyword seems to be PowerReportMissing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140867296 @DaanHoogland @resmo Not sure if this is related, but in 4.4 (and running XenServer/KVM probably any hypervisor) I see sometimes alerts when a router is live-mig

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140791892 @koushik-das could you comment, please. Regarding power off and no power state equal in some case might make sense but in general it certainly doesn't as we hav

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140665483 Currently we report only PowerOn VMs and do not report PowerOff VMs that's why we consider Missing and PowerOff as same And that's how whole code is written and e

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140643483 @bhaisaab it should be for 4.5 as well but It is not complete yet, unless we decide that we don't take any action on a missing report. I will make a PR for 4.5

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140641376 @DaanHoogland this is for just master, or also applies for 4.5; if so please send a PR for 4.5 as well. Thanks. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/829 CLOUDSTACK-8848: extra state to handle; no power report from host there no no real handling code now so this can be regarded as a DISCUSS item. It may well be an improvement over existing c