Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1168#issuecomment-162336441
code lgtm and since @ustcweizhou and @anshul1886 agree on how to solve this
and @remibergsma did the tests, i am merging this
---
If your project is set up fo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1168#issuecomment-162044783
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1168#issuecomment-161936820
@anshul1886 and @ustcweizhou can you guys go in a ring about this and 1166
please. Both address the same issue in a slightly different way.
---
If your projec
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1168
CLOUDSTACK-8845: set isRevertable of snapshot to false if the volume is
removed
Some users encounter an exception when listSnapshots.
We should set the isRevertable of snapshot to false
