Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157871920
@nlivens please have a look at
http://jenkins.buildacloud.org/job/build-master-slowbuild/2662/
two occasions of default encoding that you should make explici
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157825620
Thanks @remibergsma and all reviewers - This is great. This is a great
add to CloudStack and a great milestone for Nuage Networks. CloudStack + SDN
: a winn
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157683273
Awesome! Thanks @jburwell for the thorough review, thanks @remibergsma for
merging it in, thanks to all who helped getting this PR in! Much appreciated! :)
---
If y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157681280
Congrats @nlivens @KrisSterckx this is now merged in master and will be
included in 4.7.0. Thanks for all the work to get this in :-)
---
If your project is set
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/801
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157680581
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first now that master moved on):
```
nosetests --with-marvin --marvin
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157371668
Thanks @remibergsma, much appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157311229
@KrisSterckx @nlivens Guys, we are ready to merge this into master/4.7 now.
Since it was rebased last some weeks ago, I'll do a quick test run against
current ma
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-154401989
Great! This one is on my list to be merged once 4.6.0 is out and we start
building 4.7.0.
---
If your project is set up for it, you can reply to this email and
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-154363971
@mlsorensen I agree with that third-parties can ship their own packages
based on official release. It is more flexible for them. They can release new
packages wi
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-154335646
ok so bottom line, it seems reviews are +1 and we will merge this in 4.7.
ASAP after 4.6.0 is out, taking.
the only thing will be to keep an eye on it and
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-154200225
:+1: LGTM
@nlivens excellent work -- much appreciate the hard work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153863283
John,
I probably shouldn't respond in this thread, but from your response I
feel like much of my point was missed. In fact I had pointed out the very
I agree, John, that visual code inspection is not sufficient to "prove" the
code behaves as expected (too many variables to take into consideration
that just examining the code can easily miss problems).
I believe the idea, though, was just to protect the state of the DB since
the plug-ins don't r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153830070
This PR will be merged once 4.6.0 is out and together with some other cool
features (I counted at least 5 of them that have pull requests that are almost
ready t
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153822915
I agree with @runseb that we need to move this discussion to dev@, and
re-assess accepting the maintenance responsibly for code that cannot be tested
and verified b
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153669186
@runseb, yes in principle but we have a list of 4.7 candidates allready, so
It would cantain a little more. Let's try to contain it though.
---
If your project
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153631839
@DaanHoogland yep, so we can release this right on the heel of 4.6 release,
with just one commit to get 4.7.
---
If your project is set up for it, you can reply to t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153631129
@runseb I am with you but for 4.7 instead of 4.6. The Nuage people have
shown great effort of elegantly using our crappy plugin system and are now
maintaining i
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153629584
@jburwell I hear what you are saying, but I think it would be totally
unfair to ask this plugin provider to provide independent testing capability to
the community. N
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153518941
Thanks @mlsorensen .
We wanted to bring this plugin update in 4.6 still for the exact reason to
update the community with enriched functionality with our
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153517886
I liked Edison's approach to reviewing storage plug-in code: Since our
storage plug-ins don't really run in "sandboxes," his approach was to mainly
examine th
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153499188
I largely agree, it provides the best experience for our end users if
we can always verify that plugins are functional and maintainable. On the
flip sid
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153473377
@ustcweizhou @remibergsma this is a massive technical debt that we are
carrying with other plugins, and I think we need to stop to expanding that
debt. In some cas
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153468143
I agree with @remibergsma .
If the plugin is provided by the vendor, I would say they are responsible
for the code maintenance and update.What we need to chec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153424524
@jburwell How do we do this with other such plugins? Nicira, SolidFire &
friends. Since we do not have the hardware, there is no way to verify its
functionality
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153418530
@KrisSterckx it not a matter of trust. By contributing this code to our
community, we are responsible for its long-term support and maintenance.
Therefore, we mus
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153373302
@jburwell we have added unit testing and Marvin tests, and we posted the
results of Marvin in the Jira ticket, but in order to run the Marvin tests you
need a Nu
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153369716
@KrisSterckx this plugin is part of the code that is the responsibility of
the community. Therefore, we need to verify its operation in addition to the
core change
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153367941
@jburwell @remibergsma Pls note all again that the changes to core are
very minimal and are limited to convenience extensions only. I would expect
running the
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153351842
@remibergsma agree regarding the rebase effort. However, I am not going to
spend time testing now knowing that it will need to be retested when master is
unfrozen.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153287597
@jburwell That's fine, although this branch can be rebased easily. I would
do that before running tests anyway. But I'll focus on 4.6 first, so it makes
sense to
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153051926
@KrisSterckx I will re-review late today or early tomorrow. Also, please
bear in mind that master is current frozen. Therefore, approval of this PR
will simply pe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153051079
Hi @KrisSterckx please ping me if all required changes are in and I will do
another test run. Once that looks good, we can merge it.
---
If your project is set
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153036347
Hi
@jburwell can you pls approve if the PR looks good to you now ?
@remibergsma, can you pls suggest how we can continue ? Thanks
Kris
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-152114217
@jburwell thanks for intensive review. How does it look like? :) thanks
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-151504571
@jburwell, I think I've addressed all feedback now. Rebased against current
master again.
---
If your project is set up for it, you can reply to this email and have
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104880
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104885
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104873
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104591
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -170,20 +169,18 @@ public boolean configure(Stri
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104632
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -191,36 +188,26 @@ public boolean configure(Stri
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104314
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -112,8 +111,8 @@ public boolean configure(String
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104207
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -348,6 +866,6 @@ public String getConfigCompon
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104184
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104160
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103718
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103443
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103330
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103148
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102867
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102851
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102747
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102657
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43095672
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -409,8 +472,8 @@ private HostVO getNuageVspH
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43095562
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -129,66 +132,93 @@ public Network design(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43095297
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -114,7 +115,9 @@ public Network design(Netwo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43094914
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -483,7 +663,7 @@ protected HostVO getNuageVspHost(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43094088
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -395,65 +505,135 @@ public IpDeployer getIpDeploye
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43094017
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -367,22 +483,16 @@ public boolean applyStaticNats(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093940
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +414,17 @@ protected boolean canHandle(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093875
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +414,17 @@ protected boolean canHandle(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093698
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -194,7 +224,23 @@ public boolean configure(String
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093497
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
---
@@ -39,4 +39,21 @@ public String getNuageVspEntity() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093469
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
@@ -0,0 +1,70 @@
+//
+// Licensed to
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093502
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
---
@@ -39,4 +39,21 @@ public String getNuageVspEntity() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093482
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
@@ -0,0 +1,70 @@
+//
+// Licensed to
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093426
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java
---
@@ -0,0 +1,91 @@
+//
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093455
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java
---
@@ -0,0 +1,71 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093396
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java
---
@@ -17,28 +17,38 @@
// under the License.
/
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093404
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java
---
@@ -17,28 +17,38 @@
// under the License.
/
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093444
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java
---
@@ -0,0 +1,71 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093430
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java
---
@@ -0,0 +1,91 @@
+//
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093369
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java
---
@@ -17,38 +17,42 @@
// under the Li
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093355
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java
---
@@ -17,38 +17,42 @@
// under the Li
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093300
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java
---
@@ -0,0 +1,79 @@
+//
+// Licensed t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093317
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java
---
@@ -0,0 +1,79 @@
+//
+// Licensed t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093221
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093192
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093227
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093202
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093160
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -112,13 +147,212 @@ public boolean isDef
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093154
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -112,13 +147,212 @@ public boolean isDef
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093140
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093132
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093086
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
---
@@ -40,9 +43,61 @@ public String getVpcUuid()
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093076
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
---
@@ -40,9 +43,61 @@ public String getVpcUuid()
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093055
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java
---
@@ -0,0 +1,295 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093012
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean isL3Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093062
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java
---
@@ -0,0 +1,295 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43093020
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean isL3Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092995
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeIn
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092964
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeIn
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092950
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -58,20 +73,117 @@ public String getVpcOrS
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092627
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
---
@@ -79,4 +79,41 @@ public String getProxyUserDomainuuid(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092609
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
---
@@ -79,4 +79,41 @@ public String getProxyUserDomainuuid(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092257
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,61 @@
+//
+// Licensed to th
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43092262
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,61 @@
+//
+// Licensed to th
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091944
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License.
//
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43091957
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
@@ -17,18 +17,37 @@
// under the License.
//
1 - 100 of 528 matches
Mail list logo
