Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/787
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-152988729
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-152849621
LGTM, both scenario's tested manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-152812742
@anshul1886 for an integration test only a definition of an environment
with zwps that can be evaluated by marvin is needed. All the use cases are
covered by ex
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/787#discussion_r43580727
--- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java ---
@@ -98,9 +98,9 @@
private static final String
ORDER_PODS_B
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147970195
@remibergsma I will add the test if I gets the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147172170
@anshul1886 Thanks! Would it be possible to write a Marvin test for this so
that we can include in BVT? You already documented the manual steps so that is
nice.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147117991
@remibergsma @bhaisaab Updated the description with testing requirements.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147112390
LGTM, let's merge this after testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147111984
@bhaisaab Can you have a look at the code please?
@anshul1886 How can we test this?
Thanks!
---
If your project is set up for it, you can reply
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/787
CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed issues if vm.allocation.algorithm
is set to firstfitleastconsumed
Fixed following issues if vm.allocation.algorithm is set to
firstfitleastconsumed
11 matches
Mail list logo
