Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152500179
Thanks @remibergsma I haven't got time to retest that branch again, now
that it's in master will retry...
---
If your project is set up for it, you can repl
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152450103
@pdube I trust you, but the commit hash changed so I just run them again.
LGTM, based on a set of tests that I run on this branch (which I rebased
myself
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152300355
@remibergsma The commit didn't change, I just rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152293339
Will run the tests again since the commit changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152234419
code reviewed. nothing strange. lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-151854916
@remibergsma I rebased and repushed. I will take some screen shots later!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
repl
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-151804656
@pdube @pdion891 Could you please look at this PR? Would be nice to include
it soon.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-150777561
@pdube LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-149215099
Bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-147741954
Hey guys,
I have been re-pushing the branch for it to build on Jenkins. It has been
failing, but it doesn't seem to be related to my fixes (it seems like Jenkins
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-147112377
Hi @pdube Jenkins failed, it's probably unrelated to your change:
```
[ERROR] Internal error: java.lang.IllegalStateException: Invalid object ID
14 i
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-147090242
LGTM (did not test, just reviewed code), can you check why Jenkins failed
and also re-push to trigger them if necessary. Thanks.
---
If your project is set up for
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-143670869
Hi @pdion891 ,
But the PR is going against Master, so testing it against 4.5 only and
giving a LGTM is a bit pointless.
Could you please exe
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-143611856
@remibergsma I haven't test this PR yet on master. A previous fix has been
pushed in the past to fix s2svpn in project but didn't completely fixed it.
With this PR
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-143589882
@pdube Thanks! Can you please rebase against current master? Then we can
run the tests to verify.
---
If your project is set up for it, you can reply to this em
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-143233801
Hi @pdion891 Can you let me know what you tested please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-143194191
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/879
CLOUDSTACK-8793 Enable s2s VPN connection for projects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdube/cloudstack CLOUDSTACK-8793
Alter
19 matches
Mail list logo
