Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136696233
2 LGTMs merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136680502
@DaanHoogland I ran the following integration test on simulator. Other than
this I don't thick there is any other test for VM HA.
test/integration/smoke/
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136677170
followed the refactored logic, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136675396
in terms of refactorring i like this very much. unit tests and travis pass
so LGTM. I haven't done any integration testing, have you @koushik-das
---
If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/760#discussion_r38406769
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -383,10 +383,10 @@ public void scheduleRestart(VMInstanceVO vm, boolean
inv
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/760#issuecomment-136673890
Anyone? @kishankavala @bhaisaab @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/760
CLOUDSTACK-8785: Proper enforcement of retry count (max.retries) for â¦
â¦all work type handled by HighAvailability manager
Retry count is properly enforced for all work types in H
