Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-216208745
@rhtyd, rebased against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-216187288
@nlivens please rebase against latest master and push -f
LGTM, the removed code (publicLoadBalancerProvider key) is not referenced
in any of the actions or dat
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-138889654
Hi @nlivens
Okay... I will have a look at the code. Very weird to have it there and not
use it. :)
Cheers,
Wilder
---
If your project
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-137720078
@wilderrodrigues, this change doesn't remove the Netscaler support for VPCs
from the UI. The actual Public Load Balancer provider is derived from the VPC
offering, a
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-137691079
As @DaanHoogland suggested, if one should not see the Netscaler option,
then I fix should be put in place where a condition is checked and upon that
the drop
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-136620633
@wilderrodrigues, @DaanHoogland, I removed the field since it's not used at
all in the code.
No matter what you select in that dropdown, the value will be ignored
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-136449843
@wilderrodrigues I agree. @nlivens maybe a conditional display can be
concocted. I suppose you made this because the dropdown was hindering your
eyesight..?
-
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-136397028
Hi @nlivens ,
I'm looking int your PR and also and some documentation of Cloudstack 4.2
related to Netscaler as external load balancer for VPCs:
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/756
CLOUDSTACK-8781 : Superfluous field during VPC creation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-8781
