Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/750
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/751#issuecomment-136306330
@DaanHoogland this is just the UI :)
Alright 2LGTM, merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/750#issuecomment-136305163
Code LGTM and travis passes but I do not know what to test and the analysis
gives a lot of new issues fro findbugs which I am sure have nothing to do with
this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/751#issuecomment-136305158
Code LGTM and travis passes but I do not know what to test and the analysis
gives a lot of *solved* issues from findbugs which I am sure have nothing to do
with
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/751#issuecomment-136264200
@remibergsma @karuturi @abhinandanprateek @jburwell @DaanHoogland
@miguelaferreira review please? (same as #750)
---
If your project is set up for it, you can repl
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/750#issuecomment-135663086
Please see the experimental analysis shared here:
https://github.com/apache/cloudstack/pull/751#issuecomment-135661968
---
If your project is set up for it, you ca
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/751#issuecomment-135661968
Did some API request size and time comparisons for various pagesizes
against a large template collection (more than 4000 templates across 30+ zones);
Page S
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/751#issuecomment-135403152
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/750#issuecomment-135403029
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/751
CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/tempâ¦
â¦late listing
Due to aggregation of templates and isos on the UI/client side, it could
result
that for ea
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/750
CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/tempâ¦
â¦late listing
Due to aggregation of templates and isos on the UI/client side, it could
result
that for ea
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/739#issuecomment-135201859
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-135201596
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-134952809
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-134873788
I've updated the PR to fix the same issue for listing isos and also
addition code to de-dupe list iso and template results.
---
If your project is set up for it, y
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/739#issuecomment-134872958
I've add a similar fix for listing iso/zone page and also added code that
would de-dupe any isos and templates in the main list view.
---
If your project is set up
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/739#issuecomment-134523852
thanks @karuturi the screenshots are from a 4.5 env, I've tested this on 4.5
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/739#issuecomment-134522790
:+1: as per #740 (I havent tested it on 4.5)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-134522578
tested it and confirm the behaviour in the screenshots before and after the
fix. :+1:
---
If your project is set up for it, you can reply to this email and have y
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-134509669
@karuturi this is the screenshot from chrome devtools with the UI fix, as
you can see pagination is implemented
See in the screenshot; the listTemplates call does not call the API with a
p
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-134504869
What is the page size? can you attach a screenshot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/740
CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal templateâ¦
⦠listing
Uses listViewDataProvider to implement pagination on listTemplates API
requests in the UI, when
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/739
CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal templateâ¦
⦠listing
Uses listViewDataProvider to implement pagination on listTemplates API
requests in the UI, when
27 matches
Mail list logo
