[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135038349 lets just hope we keep this approach from now on --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135037251 @miguelaferreira it seems the default directory name 'cloudstack' (which matches the repo name) makes sense to most people, whereas remotes are defined manually

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135030089 Then everyone should align in the name of the repository directory, while having people align in the name of the remotes was too much to ask. O the irony

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135029036 @miguelaferreira Yes, this is used for the cloudstack-docs project and such. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135005019 @miguelaferreira good to know it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134934893 @ustcweizhou good catch! The idea of that script was to be a simple collection of git commands and assumed that people already understood git. But th

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134934361 @remibergsma @karuturi @miguelaferreira The 730.json is empty. I finally find the repoName (folder name) should be "cloudstack". In my env, it it not. I will

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134930757 @karuturi Just tried the code you posted, and this was the result: ```zsh jsonTmp=pr.json prAuthor=$(cat ${jsonTmp} | python -c " try:

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134899773 interesting... I do not see any such error while merging this pr It uses python to get the author info on the contents of the url https://api.github.com/repos/ap

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134882707 @karuturi Sure, I tried before the merge, but got the following message: [root@git (master)]# git pr 730 /root/git/master/tools/git/730.json ERROR

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134872980 Hi @ustcweizhou Can you use the merge-pr script next time? scripts is at https://github.com/apache/cloudstack/blob/master/tools/git/git-pr wiki explai

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-25 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134834411 @ustcweizhou is just calling the wrapper for the system in millis, which was added to the profiler. For the remaining cases, the nano time will be used (getD

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134331260 @ustcweizhou Thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj