[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37976062 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- @pdion891 good fix. I would very much more rather relying on the x

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-26 Thread pdion891
Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37973943 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- Quick hotfix is in here: https://github.com/apache/cloudstack/pull/74

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-26 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37968584 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- @pdion891 @miguelaferreira This change broke the debian packaging , be

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134699346 All builds are passing and we have 2xLGTM. Will merge it. Thanks @miguelaferreira ! --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134695303 LGTM - Deployed a full stack Nicira environment: 3 controllers, a manager, a service node and 2 KVM hypervisors, all inside my development VM: ``` #

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134632894 Force pushed again to fix NiciraNvp module structure refactoring that left out the resources configuration in pom.xml --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134595872 Force pushed again for two more license headers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134579465 Force pushed again to add the missing license headers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134576306 Force pushed to fix typos in license header of file `utils/src/test/java/com/cloud/utils/rest/RESTServiceConnectorTest.java` --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134558902 Wow, great code and tests!. Love what you did with the Restclient, will be using that for sure soon :). LGTM! --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-24 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/737 CLOUDSTACK-8758: Handle redirects in communication with NXS controller (a.k.a. Nicira NVP) When an NSX controller node is part of a cluster it will redirect API calls to the master cont