Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-153336055
@wido any chance libvirt can be upgraded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43734962
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
---
@@ -0,0 +1,108 @@
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43734583
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,219 @@
+// Licensed to the
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-153312402
@DaanHoogland @ustcweizhou Overall it seems good! It's just hard to test
this since it can break migration of VMs and you also have to deal with all the
versions of lib
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43734401
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java
---
@@ -0,0 +1,103 @@
+//
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43734254
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
---
@@ -0,0 +1,108 @@
+//
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43734224
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
---
@@ -0,0 +1,108 @@
+//
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43734035
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,219 @@
+// Licensed to the Apache
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43733925
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apache
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-152569385
FYI: Results of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-152302260
@wido @sateesh-chodapuneedi @bhaisaab can you please see if you are
satisfied with the present state (with respect to your comments)?
---
If your project is se
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-152136821
I've done the following testing manually:
1. create snapshot
snapshot-1
snapshot-2
snapshot-3
snapshot-4
2. reve
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-152136784
Guys, I just pushed some new commits to:
(1) use libvirt-java flags instead of virsh command line
(2) take snapshot of specific volume from vm snapshot
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151864368
@remibergsma no problem. I am working on some changes , I will push the
commits with rebase tomorrow.
---
If your project is set up for it, you can reply to thi
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151804289
@ustcweizhou Can you please rebase against current master (and resolve
conflict)? Thanks!
---
If your project is set up for it, you can reply to this email and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151792666
FYI,run a set of tests that on this branch (which I rebased myself first),
just to make sure no existing functionality is broken by this PR. Looking good!
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151516059
@ustcweizhou Great to see that these are there! @borisroman has some
pending patches as well. If we submit some patches towards
libvir-l...@redhat.com we can probably a
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151491475
@bhaisaab Thanks for your comments.
The motivation of CreateSnapshotFromVMSnapshotCmd is, when we create a
volume snapshot for a running vm on KVM, it will cr
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151490894
@wido @DaanHoogland I just checked the libvirt-java, the snapshot
operations with flags already exist in 0.5.1 , which did not exist in 0.4.9. I
will modify the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151447134
@ustcweizhou Can you add some unit tests for the new methods and classes,
thanks
---
If your project is set up for it, you can reply to this email and have your
re
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104526
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104502
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104473
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104400
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104351
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,191 @@
+// Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104186
--- Diff: ui/scripts/cloudStack.js ---
@@ -22,13 +22,13 @@
var sections = [];
if (isAdmin()) {
-
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151442130
@DaanHoogland Indeed, that is the case.
The problems I had were with libvirt, not the bindings. libvirt-java is
distributed via Maven and we include it in our p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151440654
So @wido , is the discussion whether we should change libvirt-java and
contribute back or use virsh?
I'm all for the first one but I recall problems you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151412595
@ustcweizhou I think we shouldn't want a enable/disable flag in the
agent.properties, it should work for anybody.
That we already have a lot of commands being e
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151204309
@wido now I got your concern.
I will change code to enable/disable vm snapshot for kvm by a global
configuration kvm.snapshot.enabled, so that someone who do
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151160292
@ustcweizhou I want a stable master branch which works all the time.
Executing binaries is not reliable as we can't do proper exception handling.
Also, virsh do
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151155683
@wido it depends on which is more important for us, more features in
cloudstack or removing virsh from cloudstack? we know "virsh" provides more
features than li
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151153457
@ustcweizhou I understand the reasoning and that you want this feature in
4.7, but there is no guarantee it will be fixed afterwards. Once the feature is
in there nobod
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151130476
@wido good to know it, thanks. I will implement some features in
libvirt-java.
I would like to keep current command line and merge it to cs 4.7, and
change i
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151094003
@ustcweizhou It's just a matter of sending patches to RedHat and they will
accept it. You can also request a new release of the bindings when you need to.
It se
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151090163
@wido I agree with you. The ideal solution is to implement the features in
libvirt-java.
At this moment, I do not know how long it will take and when it will
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42975042
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -3388,4 +3419,83 @@ public String mapRbdDevice(
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42975005
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java
---
@@ -0,0 +1,121 @@
+//
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42975057
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -3388,4 +3419,83 @@ public String mapRbdDevice(
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42966712
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,191 @@
+// Licensed to the
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151054893
@ustcweizhou
I think it's handy to include account access checks for the backup snapshot
from vm snapshot.
---
If your project is set up for it, y
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42966399
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1702,6 +1705,18 @@ protected boolean checkVmOnHost(fin
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42966249
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,191 @@
+// License
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151050842
@sateesh-chodapuneedi Thanks for your comment, I will fix it soon.
This is an implementation of vm snapshot for KVM.
You may find the FS
at:https://cwiki
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151049279
@ustcweizhou Can you please share FS or design document for this work?
It'd help greatly in reviewing this patch.
Thanks.
---
If your project is
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r42965130
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,191 @@
+// License
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/977
CLOUDSTACK-8746: VM Snapshotting implementation for KVM
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack vm-snapsh
47 matches
Mail list logo
