Github user cloudsadhu closed the pull request at:
https://github.com/apache/cloudstack/pull/691
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/691#issuecomment-179025093
for same issue Another PR created and checked in master so closing this PR
request.
---
If your project is set up for it, you can reply to this email and have yo
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-175679311
LGTM
Merging based on review, 2+LGTM and test result shared in comments
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164740710
LGTM based on code review and test case result
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164737419
Sure please find the test results below:
@summary: Test volume delete event generation in error state condition ...
=== TestName: test_volume_delete_event_err
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164736785
can you please share test result ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user cloudsadhu opened a pull request:
https://github.com/apache/cloudstack/pull/1048
CLOUDSTACK-8731-checking usage event for delete volume
checking usage event for delete volume. I have incorporated all the
suggested changes.
You can merge this pull request into a Git
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/691#issuecomment-139788478
@cloudsadhu Any update on this? If you process the review comments we can
merge it soon. Let me know if you need help.
---
If your project is set up for it, you
Github user cloudsadhu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38084154
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38073932
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38073818
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38073806
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38073739
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38073673
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r38073620
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/691#issuecomment-134917634
LGTM. @cloudsadhu are you improving it based on @ksowmya 's comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r37381189
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
GitHub user cloudsadhu opened a pull request:
https://github.com/apache/cloudstack/pull/691
CLOUDSTACK-8731-checking usage event for delete volume
@summary: Test volume delete event generation in error state condition ...
=== TestName: test_volume_delete_event_errorState | Status :
19 matches
Mail list logo
