Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-182751801
LGTM !!
Test router internal basic zone ... SKIP: Marvin configuration has no host
credentials tocheck router services
Test
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-148614442
@remibergsma: I force pushed the commit and it is showing green signal now
you can run the test.
---
If your project is set up for it, you can reply to this e
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-148344368
@prits09 Thanks! It seems Jenkins failed and I don't think it's you. Please
force-push the commit again so the rests will re-run. After that, I'll run the
test m
Github user prits09 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-147308519
squashed the commits into single commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-147172068
@pritisarap12 Please squash the commits, as there are now 2 merge commits
and I cannot proceed like this. Make sure it has a single commit. Ping me if
you need h
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-144003970
Merged the testcase in the existing testcase
test_03_restart_network_cleanup by adding support for basic setup.
---
If your project is set up for it, you can r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-143590546
@pritisarap12 Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-137535485
@miguelaferreira OK, check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-137394628
@remibergsma `rebase -i` and deleting the line of the merge commit will get
you what you want. I see that squashing would too, but then the problem is in
the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-135945903
@miguelaferreira If I recall correctly, `rebase -i` (where you'd usually
squash stuff together and such) and doing nothing, will remove the merge commit
already.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-135894663
@remi: do you mean squash to get rid of the merge commit? Wouldn't the
resulting commit have 2 parents? If so, that's not the solution.
Or do you mea
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-135887682
@pritisarap12 Please squash the commits (get rid of the merge commit). We
cannot merge it like this. Thanks!
---
If your project is set up for it, you can reply
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-135792733
Something strange with this PR. The second commit merges master into the PR
Was this an attempt to bring in new changes from master? If that was the
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/684#discussion_r37973579
--- Diff: test/integration/smoke/test_routers.py ---
@@ -796,3 +830,122 @@ def test_09_reboot_router(self):
"Router response after reboo
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/684#discussion_r37973474
--- Diff: test/integration/smoke/test_routers.py ---
@@ -796,3 +830,122 @@ def test_09_reboot_router(self):
"Router response after reboo
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/684#discussion_r37973271
--- Diff: test/integration/smoke/test_routers.py ---
@@ -796,3 +830,122 @@ def test_09_reboot_router(self):
"Router response after reboo
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/684#discussion_r37972977
--- Diff: test/integration/smoke/test_routers.py ---
@@ -796,3 +830,122 @@ def test_09_reboot_router(self):
"Router response after reboo
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-134919215
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-134489114
Testcase result:
Check if Virtual Router has same IP after network restart or not. ... ===
TestName: test_10_vr_has_same_ip | Status : SUCCESS ===
o
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-134488914
Merged the testcase in test_routers.py file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-130273467
Testcase result:
Check if Virtual Router has same IP after network restart or not. ... ===
TestName: test_01_vr_has_same_ip | Status : SUCCESS ===
o
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/684
CLOUDSTACK-8728: Testcase to Verify if VRs IP
Testcase to check if VR's IP changes if it is destroyed and re-created in
basic zone.
You can merge this pull request into a Git repository b
23 matches
Mail list logo
